Ensure ICE credentials - Githubissues

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API

Apache License 2.0

270 stars 8 forks source link

Closed mickel8 closed 8 months ago

mickel8 commented 8 months ago

We assume that:

if there are no session level ice credentials, every mline has to have the same ufrag and pwd
if there are session level ice credentials, every mline might have ufrag or pwd. When mline has ufrag or pwd it must be the same as session level ufrag or pwd

codecov[bot] commented 8 months ago

Attention: 3 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
lib/ex_webrtc/peer_connection.ex	`38.00% <100.00%> (-1.22%)`	:arrow_down:
lib/ex_webrtc/sdp_utils.ex	`87.27% <90.90%> (+5.45%)`	:arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.