search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
270 stars 8 forks source link

Add audio handling in the `echo` example #58

Closed LVala closed 5 months ago

LVala commented 5 months ago

This will be useful for me when testing RTCP stuff, but now I'm mostly working in ex_rtcp, so no need for this to wait until the whole TWCC/RTCP PR is ready.

Also, I bumped ex_rtp to 0.3 here.

codecov[bot] commented 5 months ago

Codecov Report

Merging #58 (f62c618) into master (8bf58fa) will decrease coverage by 0.27%. The diff coverage is 42.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ========================================== - Coverage 89.02% 88.76% -0.27% ========================================== Files 25 25 Lines 1057 1059 +2 ========================================== - Hits 941 940 -1 - Misses 116 119 +3 ``` | [Files](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) | Coverage Δ | | |---|---|---| | [lib/ex\_webrtc/peer\_connection/demuxer.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9wZWVyX2Nvbm5lY3Rpb24vZGVtdXhlci5leA==) | `96.15% <100.00%> (+3.56%)` | :arrow_up: | | [lib/ex\_webrtc/rtp/vp8\_payloader.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHAvdnA4X3BheWxvYWRlci5leA==) | `100.00% <100.00%> (ø)` | | | [lib/ex\_webrtc/rtp\_sender.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfc2VuZGVyLmV4) | `100.00% <ø> (ø)` | | | [lib/ex\_webrtc/rtp/opus\_payloader.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHAvb3B1c19wYXlsb2FkZXIuZXg=) | `0.00% <0.00%> (ø)` | | | [lib/ex\_webrtc/peer\_connection.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9wZWVyX2Nvbm5lY3Rpb24uZXg=) | `87.79% <0.00%> (-0.64%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Last update [8bf58fa...f62c618](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/58?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc).