search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
269 stars 8 forks source link

Fix invalid order of return values from `TWCCRecorder.get_feedback/1 #73

Closed LVala closed 4 months ago

LVala commented 4 months ago

Fixes bug merged in #63, where values returned from TWCCRecorder.get_feedback/1 are assigned to invalid variables.

codecov[bot] commented 4 months ago

Codecov Report

Merging #73 (fedbaf0) into master (22d21a5) will decrease coverage by 0.08%. Report is 1 commits behind head on master. The diff coverage is 0.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #73 +/- ## ========================================== - Coverage 88.47% 88.40% -0.08% ========================================== Files 29 29 Lines 1302 1302 ========================================== - Hits 1152 1151 -1 - Misses 150 151 +1 ``` | [Files](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) | Coverage Δ | | |---|---|---| | [lib/ex\_webrtc/peer\_connection.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9wZWVyX2Nvbm5lY3Rpb24uZXg=) | `87.25% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/73/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/73?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/73?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Last update [22d21a5...fedbaf0](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/73?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc).