Closed themusicman closed 4 months ago
Hi @themusicman, thanks for the contribution!
A couple of notes:
echo
example so we add a lot of code that we need to maintain and update as API changesI would favor adding a clause for RTCP in our echo
example that just ignores those packets. We can add a short comment too. Something like this:
defp handle_webrtc_msg({:rtcp, _packets}, state) do
# do something with RTCP packets
{:ok, state}
end
This way:
@mickel8 Fair points.
I updated the PR.
Is there anything that you want help with in regards to the project? Maybe RTCP Sender and Receiver Reports
?
Thanks for the PR @themusicman! i have deleted the comment as we are going to talk about RTCP in our guides section (in hex docs) at some point.
Is there anything that you want help with in regards to the project? Maybe RTCP Sender and Receiver Reports?
That's something @LVala is already working on! When it comes to the roadmap itself, I am working on ICE features (mDNS and TURN servers support) .
Other things I have in my mind but are not planned for 0.2 (i.e. neither @LVala nor me are going to work on them)
and many more, I will update the list later this evening :wink:
@mickel8 I was thinking about suggesting datachannels too. I will look into that some and come up with a plan for implementation and present it to you. What do you think about that?
@themusicman Sounds great!
@themusicman I've created a new section in our Roadmap where I put things that can be addressed: https://github.com/elixir-webrtc/ex_webrtc/issues/28
Wanted to contribute an example like the one in the Pion project here: https://github.com/pion/webrtc/tree/master/examples/rtcp-processing