search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
270 stars 8 forks source link

Assign mids in `create_offer` #8

Closed LVala closed 8 months ago

LVala commented 8 months ago

Quick PR with the change about MID assignment that we were discussing. Also moved to_mline function to SDPUtils to be more consistent. When we start to handle subsequent offers/answers, it's going to be refactored anyways.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
lib/ex_webrtc/rtp_transceiver.ex 100.00% <ø> (ø)
lib/ex_webrtc/sdp_utils.ex 85.71% <100.00%> (+3.04%) :arrow_up:
lib/ex_webrtc/peer_connection.ex 69.27% <66.66%> (-0.73%) :arrow_down:

:loudspeaker: Thoughts on this report? Let us know!.