search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
269 stars 8 forks source link

Sending RTCP Reports #81

Closed LVala closed 3 months ago

LVala commented 4 months ago

This PR utilises previously added RTPSender.ReportRecorder and RTPReceiver.ReportRecorder modules to actually track incoming packets and send corresponding RTCP Sender and Receiver Reports.

codecov[bot] commented 3 months ago

Codecov Report

Merging #81 (218767b) into master (e4d664e) will decrease coverage by 0.74%. Report is 1 commits behind head on master. The diff coverage is 78.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #81 +/- ## ========================================== - Coverage 88.80% 88.06% -0.74% ========================================== Files 31 31 Lines 1411 1492 +81 ========================================== + Hits 1253 1314 +61 - Misses 158 178 +20 ``` | [Files](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) | Coverage Δ | | |---|---|---| | [lib/ex\_webrtc/rtp\_sender.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfc2VuZGVyLmV4) | `100.00% <100.00%> (ø)` | | | [lib/ex\_webrtc/rtp\_receiver/report\_recorder.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfcmVjZWl2ZXIvcmVwb3J0X3JlY29yZGVyLmV4) | `96.66% <87.50%> (-1.45%)` | :arrow_down: | | [lib/ex\_webrtc/rtp\_sender/report\_recorder.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfc2VuZGVyL3JlcG9ydF9yZWNvcmRlci5leA==) | `96.96% <87.50%> (+0.54%)` | :arrow_up: | | [lib/ex\_webrtc/rtp\_receiver.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfcmVjZWl2ZXIuZXg=) | `92.30% <88.23%> (-7.70%)` | :arrow_down: | | [lib/ex\_webrtc/rtp\_transceiver.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfdHJhbnNjZWl2ZXIuZXg=) | `92.30% <86.66%> (-1.76%)` | :arrow_down: | | [lib/ex\_webrtc/peer\_connection.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9wZWVyX2Nvbm5lY3Rpb24uZXg=) | `85.39% <50.00%> (-1.75%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Last update [e4d664e...218767b](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/81?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc).