search

elixirkoans / elixir-koans

Elixir learning exercises
MIT License
2.22k stars 599 forks source link

fix(ci): pin ubuntu-20 to run github actions #281

Closed gpouilloux closed 1 year ago

gpouilloux commented 1 year ago

Fixing the issue pointed out in this GitHub workflow execution

We would be able to use ubuntu-22.04 when upgrading the OTP version to, at least, 24.2 (see here)

iamvery commented 1 year ago

Thank you for this fix! I've run into this on a couple other projects. I'm a little torn on just updating this project to target the latest elixir/erlang vs. pinning the os it runs in. You have any thoughts on that?

gpouilloux commented 1 year ago

Honestly, I think both could work but it would depend on the project itself. Personally, I would always recommend pinning to avoid such errors now and later.

You may prefer to receive deprecation notice from GitHub about ubuntu-20 runner EOL instead of having your CI breaking unexpectedly.

As for upgrading to the latest OTP version, I have still little knowledge on both this project and recent OTP/Elixir changes, so that's one more argument to do it on its own PR, and preferably, when the CI is fixed 🙂

iamvery commented 1 year ago

Sound reasoning. Thank you for the input, and for fixing the build 🙂