search

elixirlabsinc / endslaverynow

Creating the End Slavery Now project
2 stars 0 forks source link

Validate product links (& some testing updates) #10

Closed toriejw closed 5 years ago

aashnisshah commented 5 years ago

We should look at removing some of those window.alert and clean up that experience, but not important for now

toriejw commented 5 years ago

@aashnisshah The last 3 commits are new (& the previous ones are unchanged). The first new one was needed to test due to me deleting the database :) . Lmk if you'd like me to change the http addition to https!

aashnisshah commented 5 years ago

@aashnisshah The last 3 commits are new (& the previous ones are unchanged). The first new one was needed to test due to me deleting the database :) . Lmk if you'd like me to change the http addition to https!

These changes look good In the future, we could move to having a more specific URL regex to make sure the submitted url has a .com etc, but for now I think keeping it as-is works. We can also stick to just prepending the http, and then do a check in the future to see if there's a need to swap over to https instead.