elixirlearners / compounds

A Phoenix UI Components Library | Brew Your Own Interfaces.
3 stars 0 forks source link

Added the Tabs and Icons Component. #47

Closed cyanff closed 1 year ago

cyanff commented 1 year ago

Changed credo config to ensure the following doesn't fail checks:

calebgasser commented 1 year ago

We should also start writing tests. It's a drag, but the longer we wait to write them the more we're going to have to write when we do.

cyanff commented 1 year ago

I don't think we should start writing tests before 1.0 alpha. At this stage of the project, components evolve frequently as we learn more about what works and what doesn't. It would be wasteful to enter of cycle of write component -> write test -> overhaul component -> scrap and rewrite new tests. After having a draft of all components for 1.0 alpha, we could test the interactions of all the components when used together, which is much more valuable than individual unit tests.

calebgasser commented 1 year ago

I don't think we should start writing tests before 1.0 alpha. At this stage of the project, components evolve frequently as we learn more about what works and what doesn't. It would be wasteful to enter of cycle of write component -> write test -> overhaul component -> scrap and rewrite new tests. After having a draft of all components for 1.0 alpha, we could test the interactions of all the components when used together, which is much more valuable than individual unit tests.

That makes sense. It should defiantly be a priority once we hit 1.0 alpha

cyanff commented 1 year ago

Instead of using ids to link tab and content I switched to using an attribute called key. This is so that users can pass in their own ids without breaking the component's interactivity.