elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
155 stars 49 forks source link

Broken images in blog posts #100

Closed jaimeiniesta closed 3 years ago

jaimeiniesta commented 3 years ago

There are some blog posts where the images are not being properly rendered:

https://rocketvalidator.com/s/0bdee490-cff7-495a-95a3-40211cd2b5cd/i?search=Bad+value+“%7B%25+&page=1&non_doc=false

It complains about "Bad value “{% asset " and the images are broken. For example in https://beta.elixirschool.com/blog/live-view-with-channels

Captura de pantalla 2021-07-25 a las 19 01 23

This doesn't happen in the main site, https://elixirschool.com/blog/live-view-with-channels so I guess these tags were only valid in Jekyll?

doomspork commented 3 years ago

Most of this should be fix in the content branch. However, anyone adding new content is bound to add stuff that gets missed. We're going to want to work through all of the blogs once we're on the launchpad

jaimeiniesta commented 3 years ago

Alright, then I'll just mute those issues, we should review all the content before launch.