search

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
155 stars 49 forks source link

Fix Lesson TOC Issue With Intl Characters #122

Closed kinson closed 3 years ago

kinson commented 3 years ago

Overview

Resolves #111

Updated the regex used to match headings inside lessons such that accented and international characters are not excluded.

Screen Shot 2021-08-06 at 6 58 51 PM
kinson commented 3 years ago

This deployment depends on https://github.com/elixirschool/elixirschool/pull/2622 being merged to fix a regex exception thrown by the merge conflict.

doomspork commented 3 years ago

There may very well be a better way for us to handle this stuff. What is here is very much my MVP 😁 I will take a peek at this today as well @kinson 👍

kinson commented 3 years ago

There may very well be a better way for us to handle this stuff. What is here is very much my MVP 😁 I will take a peek at this today as well @kinson 👍

I'm taking a look at this now and may have figured out the issue, deploying now to hopefully resolve this issue 🤞🏼

jaimeiniesta commented 3 years ago

👍 LGTM