External links should open a new window

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework

https://elixirschool.com/

Apache License 2.0

155 stars 49 forks source link

External links should open a new window #137

Closed doomspork closed 3 years ago

doomspork commented 3 years ago

These homepage links should open a new window

doomspork commented 3 years ago

@burden @kinson either of you want to grab this?

kinson commented 3 years ago

@doomspork based on the w3 standards, it is recommended from an accessibility perspective that links do not open new tabs or windows unless it is necessary.

Normally, I would add a target="_blank" to open links in new tabs as well, but if we want to focus on accessibility here maybe it's worth leaving them as is.

doomspork commented 3 years ago

Okay! TIL