search

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
152 stars 48 forks source link

External links should open a new window #137

Closed doomspork closed 2 years ago

doomspork commented 2 years ago

These homepage links should open a new window

image

doomspork commented 2 years ago

@burden @kinson either of you want to grab this?

kinson commented 2 years ago

@doomspork based on the w3 standards, it is recommended from an accessibility perspective that links do not open new tabs or windows unless it is necessary.

Normally, I would add a target="_blank" to open links in new tabs as well, but if we want to focus on accessibility here maybe it's worth leaving them as is.

doomspork commented 2 years ago

Okay! TIL