Broken link in navigation for `Advanced > 6. Specifications and types`

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework

https://elixirschool.com/

Apache License 2.0

155 stars 49 forks source link

Broken link in navigation for `Advanced > 6. Specifications and types` #151

Closed zorn closed 3 years ago

zorn commented 3 years ago

The link for the lesson Advanced > 6. Specifications and types within the navigation bar currently links to # but the lesson can be found if you go spelunking for it.

https://elixirschool.com/en/lessons/advanced/typespec

doomspork commented 3 years ago

Thanks for the report @zorn! We will look into this

kinson commented 3 years ago

Yes, thanks @zorn , I also just noticed the same behavior for Metaprogramming (https://elixirschool.com/en/lessons/advanced/metaprogramming) - the page exists but the menu link is not working.

rsmidt commented 3 years ago

In the _lesson_menu template the atom is :typespecs while in the lesson config it's :typespec. I can file a PR later.

The same seems to be true for :metaprogramming vs :mtaprogramming.

kinson commented 3 years ago

This was fixed in #158 - thanks again @rsmidt & @zorn !