search

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
154 stars 49 forks source link

Fix header regex not consuming closing tag (#166) #168

Closed vclayton closed 3 years ago

vclayton commented 3 years ago

Because the regex was using lookahead the closing tag was not being included in the regex match and therefore not being replaced.

Also fixed the test case which was still expecting two closing h4 tags.

doomspork commented 3 years ago

Thank you @vclayton and @jaimeiniesta 🙏

jaimeiniesta commented 3 years ago

Awesome, when is this going to be deployed? I'm still seeing the issue on the site.

doomspork commented 3 years ago

It should have auto-deployed but I manually triggered it 👍

jaimeiniesta commented 3 years ago

Thanks, @doomspork !

Unfortunately, the issue is still present on the site. Either the site wasn't properly deployed, or this PR hasn't fixed it as we expected:

https://rocketvalidator.com/s/2b5cef9e-41bd-48f4-bdb5-339c8cf6275b/i?search=Stray+end+tag

jaimeiniesta commented 3 years ago

Ah, I see what happened here, this PR merged the changes by @vclayton into my branch, not into master.

Here's a new PR to merge it into master:

https://github.com/elixirschool/school_house/pull/169