search

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
155 stars 49 forks source link

HTML issue: some sections lack heading #176

Closed jaimeiniesta closed 3 years ago

jaimeiniesta commented 3 years ago

Our next biggest issue is this one:

https://rocketvalidator.com/s/0d798b32-e799-4867-8f8c-45698197f2e0/i/115600579

You can read the guide about "Section lacks heading".

It usually means that in web pages like https://elixirschool.com/bg/lessons/intermediate there's a <section> that doesn't have a heading (like h1, h2) etc. to give a title to that section.

The HeadingsMap Chrome Extension may help here.

jaimeiniesta commented 3 years ago

For example, this p could be converted to an h1 and then adjust CSS accordingly:

https://github.com/elixirschool/school_house/blob/master/lib/school_house_web/templates/lesson/_intermediate.html.heex#L4

This would give this section a heading.

Alternatively, as this page has only one section then maybe a better fix would be converting this section in a div:

https://github.com/elixirschool/school_house/blob/master/lib/school_house_web/templates/lesson/index.html.heex#L1

I mean, why declare a section if there's only a section? It makes sense to have sections when we have many within a document, and that's why each section needs a heading :)

sujinleeme commented 3 years ago

Hello. @jaimeiniesta. I would like to take this ticket. Could I grab it?

jaimeiniesta commented 3 years ago

Sure @sujinleeme - also ping me at jaime AT rocketvalidator.com if you'd like a free account on the tool so you can run your own site validations :)