search

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
155 stars 49 forks source link

Render markdown code blocks #188

Closed fmterrorf closed 2 years ago

fmterrorf commented 2 years ago

Fixes https://github.com/elixirschool/school_house/issues/187

Before Screenshot from 2022-03-05 12-46-27

After Screenshot from 2022-03-05 12-45-53

Before Screenshot from 2022-03-05 12-47-16

After Screenshot from 2022-03-05 12-47-58

fmterrorf commented 2 years ago

Oops. I didn't notice that the test is failing. I'm going to fix that shortly

fmterrorf commented 2 years ago

Thanks for the review @kinson ! Sorry I haven't looked at this PR for a while. I'll try to push in the changes by today

doomspork commented 2 years ago

@fmterrorf would you like some help incorporating these changes and getting your work merged? I'd be happy to help as I'm sure is @kinson. 😁

fmterrorf commented 2 years ago

@fmterrorf I went ahead and accepted @kinson's suggestions so that you don't need to get anything tada Thanks so much for making this fix pray

Thanks for pushing it! Sorry i got a little bit busy and forgot about this PR