🐛 Fix "Coming Soon" badge translation in Lesson popover

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework

https://elixirschool.com/

Apache License 2.0

155 stars 49 forks source link

🐛 Fix "Coming Soon" badge translation in Lesson popover #202

Closed brehen closed 2 years ago

brehen commented 2 years ago

Noticed during the translation of the Norwegian translation file that the badge "Coming Soon" wasn't being translated.

This text is resolved in the file changed for this PR, and was the only place that didn't call gettext directly. This file doesn't use the :view of SchoolHouseWeb, so the Gettext module needs to be imported manually for this to work.

Verified that it works based on the Norwegian translation that I have open in https://github.com/elixirschool/school_house/pull/201

brehen commented 2 years ago

This is great 💥 ! Do you mind [extracting[(https://hexdocs.pm/gettext/Mix.Tasks.Gettext.Extract.html) this translation into the locale files?

Yeah!

I moved the exclamation point out from the translation id, leaving us with no need to have a clone for the same id. 🥷