Closed Benjamin-Philip closed 2 years ago
Should I replace instances ofApplication.get_env
with Application.compile_env
? That should fix the failing workflow.
@Benjamin-Philip let's make that change and give it a look to make sure everything works as expected 👍
Thanks for the PR!
@doomspork On investigation I found that the warning:
Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead
is mostly from AppSignal and is passed when we use AppSignal.Phoenix.view
in SchoolHouseWeb.view
. It is also passed when we use AppSignal.Phoenix
in SchoolHouseWeb.Endpoint
.
Additionally using Gettext
in SchoolHouseWeb.Gettext passes one instance of the warning.
Since this is something that needs changes upstream, there are 4 things we could do:
--warnings-as-errors
flag temporarilyThis is possibly a bug in the Elixir compiler as these are errors from using an external module.
Scratch that. Upgrading gettext
and appsignal_phoenix
fixed everything.
Done.
I haven't tested with asdf though as I don't use it.
This commit upgrades the Elixir version used in the Docker image and the Continuous Integration to v1.14.