search

elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
152 stars 48 forks source link

Upgrade npm packages related to Tailwind #206

Closed brehen closed 1 year ago

brehen commented 1 year ago

Noticed that the project was using a rather outdated version of Tailwind for the assets, namely 2.2.7, that was released August last year.

During a previous PR I attempted to solve something using a class that hadn't been implemented last summer, and thought it would be nice to be able to partake in more recent features of tailwind while further developing the project.

Did a v2 to v3 migration at my workplace when that was released, so I'm pretty sure I've remembered to fix the breaking changes that can occur. Mostly key purge has been renamed to content for determining what files should be included in tailwind processor.

Also surmised a prettier config based on how the JS has been written, in order to have one single format that all formatters use. ✨

I accidentally branched out of the same branch as for https://github.com/elixirschool/school_house/pull/201, so this branch is slightly dependent on that branch being merged at some point. Any update on that? 😄

kinson commented 1 year ago

Thanks for making this migration :tada: ! Once #203 is merged and this is updated I'll pull it down and spot check the upgrade locally. Otherwise, this all looks good to me :boom: