elixirschool / school_house

The new era of Elixir School now powered by @phoenixframework
https://elixirschool.com/
Apache License 2.0
155 stars 49 forks source link

Update post.html.heex to include date of post #216

Closed codeanpeace closed 1 year ago

codeanpeace commented 1 year ago

It'd be great to include the date posts were first created in the blog posts themselves. This is generally helpful to get an idea of how "up to date" the code examples will be. Even better would be to nudge authors to specify the versions of Elixir, Phoenix, LiveView, etc. used in the code examples.

doomspork commented 1 year ago

This is a great change @codeanpeace! ~Could you look into the failing CI?~

Actually it appears main is messed up. I'll look into that.

kinson commented 1 year ago

Thanks for contributing to Elixir School, and for your patience getting this pr reviewed @codeanpeace ❤️

codeanpeace commented 1 year ago

Also, what are your thoughts on updating the elixirschool readme section Posting an Article to nudge authors to specify the versions of Elixir, Phoenix, LiveView, etc. used in their code examples.

Another approach could be to extend the article metadata with an optional :versions field e.g.

%{
  author: "Author Name",
  author_link: "https://github.com/author_github_account",
  tags: ["phoenix", "liveview"],
  versions: [{:phoenix, "~> 1.7.6"}, {:phoenix_live_view, "~> 0.19.0"}]
  date: ~D[YYYY-MM-DD],
  title: "Full Article Title",
  excerpt: """
  Article short preview text
  """
}
--- 
kinson commented 1 year ago

I think that would be a great idea! I created an issue based on that suggestion 🙂