search

elizagamedev / android-textbender

Bend Android text to your whim.
GNU General Public License v3.0
39 stars 4 forks source link

Fix context menu not working #4

Closed Aquafina-water-bottle closed 1 year ago

Aquafina-water-bottle commented 1 year ago

The context menu no longer works in certain apps (namely, the latest beta version of AnkiDroid.) I'm honestly not sure why it no longer works, and I also have no idea why this change even fixes it, but I copied/pasted this answer and everything magically works for some crazy reason.

Tested on AnkiDroid, Chrome, Firefox, Kiwi Browser. Currently trying to send it out for others to test to make sure it doesn't break any existing functionality, hence why it's a draft PR right now.

Full discussion on TMW discord, in the textbender thread.

elizagamedev commented 1 year ago

LGTM. I think you can merge the two intent-filters, though.

elizagamedev commented 1 year ago

Oh, forget what I said about merging them, I spoke carelessly. I'm ready to merge this, but updating the dependencies should probably be a separate PR/commit.

Aquafina-water-bottle commented 1 year ago

Fixed in https://github.com/elizagamedev/android-textbender/commit/57b853f42fe01e89d8d770e9ba0ae933585b3e0f, thank you!