elizagrames / litsearchr

litsearchr is an R package to partially automate search term selection for systematic reviews using keyword co-occurrence networks. In addition to identifying search terms, it can write Boolean searches and translate them into over 50 languages.
https://elizagrames.github.io/litsearchr
101 stars 24 forks source link

suggested fixes for check_recall() #49

Open luketudge opened 3 years ago

luketudge commented 3 years ago

beb0e7e572cb86caaf35d08ff958bdc1648b36f6 for #47 Hyphens are now exempted from removing punctuation, which preserves the character alignment of hyphenated vs. non-hyphenated variants ('black-backed' vs. 'black backed', 'cognitive-behavioral' vs. 'cognitive behavioral', etc.) There is perhaps a reasonable alternative here, which is to instead replace hyphens with spaces, so maybe think about this one first and feel free to reject it if you have a different preference.

d0c490722796eb1d34cef708a473b2177c610d07 for #48 Now returns a dataframe instead of a character matrix. I think this is fairly uncontroversially better but of course changing the type of a return value is a potentially breaking change if people are already depending on the matrix behavior in their code.