search

elizagrames / litsearchr

litsearchr is an R package to partially automate search term selection for systematic reviews using keyword co-occurrence networks. In addition to identifying search terms, it can write Boolean searches and translate them into over 50 languages.
https://elizagrames.github.io/litsearchr
101 stars 24 forks source link

Add dependency for newer version of synthesisr #50

Closed mcguinlu closed 3 years ago

mcguinlu commented 3 years ago

Hi @elizagrames,

Hope the summer is going well for you - or as well as possible given the circumstances!

A very small thing for you - litsearchr seems to depend on the newest version of synthesisr (>=0.3.0) but this is not declared in the DESCRIPTION. I only discovered it when I was playing around with the development version of litsearchr and got an error in one of the functions:

litsearchr::remove_duplicates(naiveimport,
                                 field = "title",
                                 method = "string_osa")
Error in synthesisr::find_duplicates(data = df, match_variable = field,  : 
  unused argument (match_variable = field)

I went investigating, and it turns out that I had version 0.2.0 of synthesisr installed from ages ago - updating it to the newer version fixed the issue.

I've added the version dependency in this PR to try and reduce your workload - hope that's okay/helpful!

elizagrames commented 3 years ago

This explains so many random issues that are inconsistent when different people run the same code. Thank you!!!

mcguinlu commented 3 years ago

Haha, I know - it was by complete chance that I noticed it, because unless you already had a version of synthesisr you'd never experience the issue! Glad to be of help.