elizeuangelo / fvtt-module-combat-music-master

MIT License
5 stars 1 forks source link

[Bug] When combat starts, one track from combat playlist is played then all stops #8

Open r-valyar opened 1 year ago

r-valyar commented 1 year ago

When I configure a combat playlist and begin combat, the module properly plays the first track and afterwards it is silence, unless I manually go to Audio tab and manually restart the play list.

I don't use per-encounter or token tracks.

Below is the configuration of the module and the track. Not sure if misconfiguration or bug.

image image


Foundry version v10.291 and v11.300 Module version 1.4.4 Browser: Firefox/ Edge latest

elizeuangelo commented 1 year ago

It should respect whats configured in your Playlist. In your case sequential play in the "shuffled" playlist. I can't reproduce what you described so it might take a while to fix it.

What you are describing in theory COULD be reproduced by the MOD IF there is a token with higher priority than the default playlist, configured to play a specific track, and the track is not configured to loop. But you are testing with unconfigured tokens, right?

r-valyar commented 1 year ago

I don't have token with playlist, just the configuration deployed. Not sure how to help in the troubleshooting, give me few pointers and I will do it. For now plan to keep the console open and see what happens.

elizeuangelo commented 1 year ago

If you play a music from that playlist manually, when the song ends it automatically plays the next song, correct?

apoapostolov commented 1 year ago

Each track in a combat playlist should be set up to loop in its properties. This is a very standard setup for combat music the DM should do for every song manually. Otherwise, the behavior is probably what @r-valyar describes as one song plays, is not set to loop, and thus it will not loop and there's silence. From the screenshot above I can see the loop icon is greyed/turned off for all longs.

https://user-images.githubusercontent.com/63558984/244300670-97f02a3d-2388-4481-975e-969a86d6df8c.png

I think solutions could be:

Personally, I am aware I need to set tracks to loop and have done this for Maestro, so perhaps Maestro could work even if they were not set up that way and CMM has not accounted for that case. In that case I think solution 1 above is the one that fixes the issue faster.

apoapostolov commented 1 year ago

Since 100s of tracks need to be manually set to loop in some cases, the mod https://github.com/Mallander/playlist-enhancer includes Bulk Edit tasks that let you update properties of all tracks in a playlist - set their loop state, their fade duration or their volume.

elizeuangelo commented 1 year ago

The behavior in my setup is playing the next song when one isn't with 'loop' toggled. I tested both manually and within the module, and it worked that way.

apoapostolov commented 1 year ago

Then the issue may be with the logic to pick another track? OR some tracks may have erroneous file links, and thus result into hard stop for the playing routine, although I doubt that is the case since Ivan Duch mod pack is unlikely to have broken links.

apoapostolov commented 1 year ago

@elizeuangelo did you test it with all playlist play modes? Some modes (simultaneous for example, which is used to play all slongs, or soundboard which plays only upon manual play) may be causing issues?

elizeuangelo commented 1 year ago

In his screenshot he uses a shuffled playlist, wich I tested.

r-valyar commented 1 year ago

@elizeuangelo does it work when you enable this module: https://github.com/ironmonk88/monks-sound-enhancements ?

elizeuangelo commented 1 year ago

It works even with that module enabled. Does it show any errors in the console when reproducing the issue?

r-valyar commented 1 year ago

When I start combat I see the following in the console, not sure if this is related, it points to Moulinette modules image

When track is changed image

elizeuangelo commented 1 year ago

There were a few bugs in manual playlist selection wich got fixed in the last update, could you tell me if its working for you now?

r-valyar commented 1 year ago

@elizeuangelo , after conversation with @apoapostolov , it seems the module is working as intended - single track is played from playlist and song must be set to loop, no matter if the playlist itself is set to shuffle or sequential. I misunderstood the module's design - I thought that when playlist is selected, it will either shuffle or rotate all tracks.

I guess this will be new feature, instead of bug.

elizeuangelo commented 1 year ago

If you select the playlist (no track selected) it should play shuffle or sequential in accordance to whats programmed in the playlist.

r-valyar commented 1 year ago

Hm, in this case it is not playing anything but the first song. Not sure how to troubleshoot further

elizeuangelo commented 1 year ago

Get my contact with Apostolov and talk with me in Discord. I need to test in your game because I simply can't reproduce this.

apoapostolov commented 1 year ago

Just to clarify from my side

What we didn't test with Valyar is how the 2nd case would work with each playlist mode. It may be that in some modes it would not play random distinct tracks in order/random.