search

eliztan / pe

0 stars 0 forks source link

Cannot choose "yes" for satisification of a generated gift #2

Open eliztan opened 2 months ago

eliztan commented 2 months ago

image.png

When attempting to choose "yes" when prompted if the user is satisfied with the generated gift through the gift command, the app crashes.

Steps to replicate:

  1. Type in any gift commands
  2. Upon prompting, type yes
nus-pe-bot commented 2 months ago

Team's Response

By right upon entering any gift commands, the gift suggested should not be null as shown in the screenshot as this issue was raised before and has been adequately addressed in v2.1 release. Require more information on how the tester run the application and actions afterwards. App naturally crashes if users try to accept a null (empty) suggestion. The following output should be what users should receive if they have not exhaust all the gifts in the given gender category:

image.png

The following output is what users should see if they respond no and exhausted all suggestions for the given gender category:

image.png

User can try copying the JAR file to another directory and run again. When trying, use java -jar "[CS2113-T11-2][Flirt_and_Fork].jar" to ensure that it is properly initiated. Also, check that the GiftList.txt file is present in the data folder upon running for the first time. DO NOT make changes to the data files as this may result in unintended consequences.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

The Gift function does not work

image.png

When attemping to generate a gift idea using any of the gift keywords (gift, gift female, gift male, gift unisex), the only gift option that shows up is "null" unlike what the UG demonstrates.

Steps to replicate:

  1. Type in any of the gift commands.

[original: nus-cs2113-AY2324S2/pe-interim#1773] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hello! I think you are the same person who wrote several bug reports regarding access issues of the gift function (particularly might be because the database was not correctly initialised on your end), so I'm going to copy-paste my same response: I suspect that there might be some issues in how you run the App which resulted in the GiftList not correctly being initiated? Check in the directory where you put the JAR file in, under the data folder, ensure that GiftList.txt file is within it and not empty. DO NOT change the .txt files as this might lead to unintended consequences! Alternatively, copy the JAR file into a new empty folder, cd into the path of the folder and run java -jar "[CS2113-T11-2][Flirt_and_Fork].jar". Ensure that the GiftList.txt file is within the data folder (and not empty) after first starting the App. Do let us know if the gift function still does not work after trying the abovementioned!

You should be receiving the following outputs:

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.CannotReproduce`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]