search

eljoujat / eclipseimpexeditor

Unofficial Eclipse plugin for SAP CX
Apache License 2.0
15 stars 3 forks source link

ValidateImpexAction doesn't use configured hostname #26

Open bjmi opened 7 years ago

bjmi commented 7 years ago

The default hostname string "http://localhost:9001/hac" is always used for validation action and not the configured url in preference page. In ValidateImpexAction

final String hostName = store.getDefaultString(PreferenceConstants.P_HOST_ENDPOINT_STRING); should be replaced with String hostName = store.getString(PreferenceConstants.P_HOST_ENDPOINT_STRING);

Please also rename the label "Host name:" to "URL to HAC:" or something that better express that it must be a URL.

eljoujat commented 7 years ago

Hello @bjmi Thanks for the issue :+1: . I'm able to reproduce and i will fix it next release