elk-zone / elk

A nimble Mastodon web client
https://elk.zone
MIT License
5.38k stars 554 forks source link

Improve the way to follow someone #1020

Open nicosomb opened 1 year ago

nicosomb commented 1 year ago

Clear and concise description of the problem

When someone follows me, I think that finding the way to follow him/her is not so obvious. See the screenshot.

B3A87BCC-6AAB-4881-94FD-3762E92A0224

The « follow area » tells me that the user follows me.

Suggested solution

Replace the text by « follow back ».

Maybe it’s in fact a translation issue.

Alternative

No response

Additional context

No response

stackblitz[bot] commented 1 year ago

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

cyberalien commented 1 year ago

Maybe it’s in fact a translation issue.

Original English text is Follows you, on hover changes to Follow back

ZMYaro commented 1 year ago

I know it would add another element to the screen, but should we consider adding a text label (like Twitter et al.) to say someone follows you. I agree it is confusing when the button only shows its action on mouseover, especially when a lot of people access Elk from touch screens and cannot see the hover state.

edimitchel commented 1 year ago

I'm fully agreeing with @ZMYaro ! Also, as Mutuals doesn't work well for all languages (cc @patak-dev), we should add that information that the account is following you.

ayoayco commented 1 year ago

Hover is also not very good for accessibility. We need the action to be clear in the button without needing to hover.

boehs commented 1 year ago

Personally I'm in favour of just entirely replacing Follows you with Follow back

edimitchel commented 1 year ago

Personally I'm in favour of just entirely replacing Follows you with Follow back

This could be made on french side

👇🏻

boehs commented 1 year ago

Redopvedin https://github.com/elk-zone/elk/commit/98a1b2dccb1de4052f775811ffa4d8bb3963c069

boehs commented 1 year ago

Want to see other languages in first

edimitchel commented 1 year ago

What do you mean? You want to get feedback from other languages?

ping @elk-zone/translators

boehs commented 1 year ago

What do you mean? You want to get feedback from other languages?

ping @elk-zone/translators

French is a good start, just not enough for the issue to be closed I think

prazdevs commented 1 year ago

IMO, the button should always be "follow" or "follow back", and another mention out of the button could say "follows you". I think twitter has something like this ?

text change on hover is very bad ux/a11y.

edimitchel commented 1 year ago

I think getting another mention outside of the button would be IMHO a bed ux/a11y as the information is not clear. That's said we could add the aria-label on the button and use "follows you" but the main text would be the action "follow back" which means indirectly the user is following you.

juliemoynat commented 1 year ago

Having an aria-label content different from the visible label is a WCAG failure. It's very bad for people using voice control.

I agree with @prazdevs idea. It's the best solution. The fact that someone is following you is just an information. It can't be a button name because there is no associated action with this name that people could understand.

joelanman commented 1 year ago

Just to say I agree that the current approach is not accessible due to relying on hover. For example if I use the keyboard to focus a button that says 'Following', there's no indication of what the button does. I only get that if I hover (Unfollow). I think the buttons should just say what they will do

shuuji3 commented 1 year ago

I tried implementing changes in #2397 with the following features:

Let me know if any feedback. 🙂

joelanman commented 1 year ago

@shuuji3 looks great thanks!