PWA: Refreshing when on a thread breaks back nav and loses timeline position

eamodio commented 1 year ago

Pre-Checks

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] Providing a screenshot or video to reproduce the issue or show visually what was meant.
[ ] I am willing to provide a PR.

Describe the bug

I (too often) end up trying to scroll up on a thread (or want to "pull to refresh" on the thread) and end up triggering the default Chrome (I'm on Android 13) pull-to-refresh on the thread. This breaks any backward navigation and context (timeline position, etc).

It would be great if there was an "app" implemented pull-to-refresh that wouldn't break the above or something. Related, because there are no spinners or other progress indicators when opening a thread, I end up triggering the above more often, because I think I should be able to scroll to get to the root thread, but it hasn't loaded yet.

Reproduction video or screenshot

No response

Additional Context

No response

stackblitz[bot] commented 1 year ago

Start a new pull request in StackBlitz Codeflow.

edimitchel commented 1 year ago

Request close to the issue #653, right?

eamodio commented 1 year ago

They are related but I don't think they are the same. Though depending on how that is fixed it might seem like it fixes this issue (and might for the most common use-case).

But if I had a bunch of navigations in my history and I refreshed that fix would only get me to the timeline, not where I actually came from

elk-zone / elk