search

elk-zone / elk

A nimble Mastodon web client
https://elk.zone
MIT License
5.51k stars 564 forks source link

Incorrect notification that merges two posts together when a user favourites a post #3023

Closed mattwelke closed 3 weeks ago

mattwelke commented 4 weeks ago

When someone favourited a post, the notification I received appears to have merged the post with another and displayed it as a single post that the user favourited:

Image

These are the two posts:

Image

Image

You can see how the user did not actually favourite the second post. They only favourited the first:

Image

There was no GitHub template when I opened this issue, so I don't know which other information I should attach for debugging purposes. Feel free to ping me if you want me to attach more!

shuuji3 commented 3 weeks ago

Hi, thanks for reporting the issue. Is this happening on the stable version of Elk (https://elk.zone)? If so, we recently fixed the notification issue by #3014, which was deployed as a Canary version (https://main.elk.zone). Could you try the Canary version to see if the same issue has been solved?

mattwelke commented 3 weeks ago

@shuuji3 It was actually tricky to reproduce. I found that once another notification came in, it seemed to kick things back into being correct. This is the version that is running right now on the instance;

A nimble Mastodon web client

Version

canary (f8b4f70@main)

Built

July 16, 2024 at 12:47:05 AM

if you want, we can close this and assume it won't happen again. If it does, we can re-open it. If I'm the one posting again in the future, I'll make sure to read the reproduction steps in those linked tickets and try to put together a reproduction.

shuuji3 commented 3 weeks ago

Yes, that would be helpful. The above version seems to be a bit old and the fixed version will be available in the next stable version (release date is TBD) or the Canary version after Oct 26.

I'm closing this now but feel free to reopen it anytime 🙂