search

elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

Remove create_function #2013

Closed joshuaadickerson closed 9 years ago

joshuaadickerson commented 9 years ago

Seems there's 3 places where create_function() is used but there's no point in using it anymore. Twice in Subs.php for the [ftp] tag and once in ManagePermissions.controller.php

Vekseid commented 9 years ago

This would be a 1.1 element since depreciating create_function is a php 5.3 thing.

emanuele45 commented 9 years ago

I can count 5 places. :stuck_out_tongue: I thought you (Joshua) and Spuds squashed all of them, but probably some slipped through.

Spuds commented 9 years ago

We moved a lot of them to actual functions (as they were actually used multiple times but done as create functions in multiple places) The remaining, at least for 1.0 were left because of the 5.2 thingy.

In 1.1 the remaining (and maybe even some of the ones that were moved) should be able to become closures I would think. Certainly something to revisit!

joshuaadickerson commented 9 years ago

I thought we did too.

Easy tag as well?