search

elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

Mentions Controller #2252

Open Spuds opened 9 years ago

Spuds commented 9 years ago

So many of the methods in that class are depreciated in 1.1. In this instance I'd prefer they just be removed to avoid confusion. Also unless someone is willing to test that all those depreciated methods still work as expected, they are likely not just depreciated but broken.

Could add a large block comment that states the function xyz were depreciated and replaced with xyz::bla calls or whatever.

emanuele45 commented 9 years ago

The methods should be exactly the same as in 1.0, so they should workTM, but remove them it's fine with me.

emanuele45 commented 9 years ago

I was looking at that, and noticed that at least some of the deprecated ones (e.g. action_add) are still used (see Post_Controller). Probably I didn't spend time on removing them based on the fact I set the "deprecated" flag. /me is quite lazy you know :stuck_out_tongue:

Anyway, I'd move this to beta 2 considering the fact they are still used. :innocent:

Spuds commented 9 years ago

LOL ... thats fine with me. When they get marked as depreciated it lights up the old IDE with soft errors, sometimes its the function, sometimes is depreciating a param (which gets picked as as a depreciated function in general)

emanuele45 commented 8 years ago

Are you using phpstorm?

BTW, let's move to 2.0, it would just be a few months anyway before they go. :stuck_out_tongue:

Spuds commented 8 years ago

Yes to both.