elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

BBCode not disabled? #3034

Closed interlab closed 7 years ago

interlab commented 7 years ago

Maybe I do not understand how this works and it's not a mistake ...

elk 1.1

http://.../index.php?action=admin;area=postsettings;sa=bbc

I disable the bbcode and it is no longer in the editor, but it still works when viewing the topic!

emanuele45 commented 7 years ago

Any code in particular? I tested with some and they are disabled as expected.

interlab commented 7 years ago

Example:

Create new post with data:

[center]qwerty[/center]

[quote] :) [/quote]

and disable quote and center.

Results in smf 2.1 b3 2017-10-31_08-48-26

elkarte 1.1 2017-10-31_08-46-24

interlab commented 7 years ago

Settings 2017-10-31_08-55-52

2017-10-31_08-56-44

emanuele45 commented 7 years ago

Looks like a refactoring hiccup, try changing in ParserWrapper.php.

$this->codes = new Codes($additional_bbc, $this->disabled);

with:

$this->codes = new Codes($additional_bbc, array_keys($this->disabled));

that should fix it.

emanuele45 commented 7 years ago

Reading your first report I thought you were talking about the "global" enable bulletin board code (BBC) and this one was working for me. :wink:

interlab commented 7 years ago

it works

interlab commented 6 years ago

if you make a new tag bbc_codes_parsing or integrate_additional_bbc. what is the difference? integrate_additional_bbc overrides bbc_codes_parsing?

emanuele45 commented 6 years ago

Mostly the same thing, no practical differences.