elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

Various 1.1.9 fixes applied #3694

Closed Spuds closed 1 year ago

Spuds commented 1 year ago

Another compilation of random fixes.

I can't believe how many tests got broken in since the last PR , what a pain in the arse and a senseless waste of time.

codecov-commenter commented 1 year ago

Codecov Report

Base: 31.10% // Head: 30.57% // Decreases project coverage by -0.53% :warning:

Coverage data is based on head (98e04de) compared to base (cb51523). Patch coverage: 19.35% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3694 +/- ## ================================================= - Coverage 31.10% 30.57% -0.53% - Complexity 16375 16417 +42 ================================================= Files 432 432 Lines 75160 84376 +9216 ================================================= + Hits 23376 25796 +2420 - Misses 51784 58580 +6796 ``` | [Impacted Files](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte) | Coverage Δ | | |---|---|---| | [sources/ElkArte/AdminController/ManageBans.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0FkbWluQ29udHJvbGxlci9NYW5hZ2VCYW5zLnBocA==) | `0.00% <0.00%> (ø)` | | | [sources/ElkArte/AdminController/ManagePaid.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0FkbWluQ29udHJvbGxlci9NYW5hZ2VQYWlkLnBocA==) | `3.79% <0.00%> (-1.72%)` | :arrow_down: | | [...ces/ElkArte/AdminController/ManageRegistration.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0FkbWluQ29udHJvbGxlci9NYW5hZ2VSZWdpc3RyYXRpb24ucGhw) | `7.94% <0.00%> (+2.15%)` | :arrow_up: | | [...es/ElkArte/AdminController/ManageSearchEngines.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0FkbWluQ29udHJvbGxlci9NYW5hZ2VTZWFyY2hFbmdpbmVzLnBocA==) | `4.30% <0.00%> (-3.32%)` | :arrow_down: | | [sources/ElkArte/AdminController/ManageServer.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0FkbWluQ29udHJvbGxlci9NYW5hZ2VTZXJ2ZXIucGhw) | `42.04% <0.00%> (+0.77%)` | :arrow_up: | | [sources/ElkArte/Agreement.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0FncmVlbWVudC5waHA=) | `54.65% <0.00%> (-1.98%)` | :arrow_down: | | [sources/ElkArte/Controller/Attachment.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0NvbnRyb2xsZXIvQXR0YWNobWVudC5waHA=) | `9.58% <0.00%> (-0.49%)` | :arrow_down: | | [sources/ElkArte/Controller/PersonalMessage.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0NvbnRyb2xsZXIvUGVyc29uYWxNZXNzYWdlLnBocA==) | `25.11% <0.00%> (+1.69%)` | :arrow_up: | | [sources/ElkArte/Controller/Post.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0NvbnRyb2xsZXIvUG9zdC5waHA=) | `40.93% <0.00%> (-1.28%)` | :arrow_down: | | [sources/ElkArte/Converters/Html2BBC.php](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte#diff-c291cmNlcy9FbGtBcnRlL0NvbnZlcnRlcnMvSHRtbDJCQkMucGhw) | `42.11% <0.00%> (ø)` | | | ... and [217 more](https://codecov.io/gh/elkarte/Elkarte/pull/3694?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkarte)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.