Closed tinoest closed 3 months ago
Patch coverage: 53.33
% and project coverage change: +0.17
:tada:
Comparison is base (
c5730e1
) 30.45% compared to head (fa128c0
) 30.62%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I picked the Redis.php
file from this PR and renamed it to Predis.php
because I also added a method to use the pecl phpredis
extension.
I'm still unsure what to do about the predis libray itself. I'm inclined to add that to composer
and start using the vendor library in place of the ext
library going forward. Then this would be added to the suggest section and the core would only have the single interface file to translate elk speak to predis speak.
Also sorry this took me so long to get to, life happens!
For completeness, the new PR is https://github.com/elkarte/Elkarte/pull/3801
It has both methods and also adds (back again) the cache password and UID values as Redis
can have auth()
enabled so we need to support that. I did not add that to the predis method just yet but did test it with phpredis
Closed as this was incorporated in https://github.com/elkarte/Elkarte/pull/3801
@Spuds not sure if you want this as part of the core, or if I am doing this the right way.
The ip for the redis server is hardcoded currently, so if you do a checkout edit this line to what your ip is to get it working.
$this->obj = new \Predis\Client('tcp://172.19.0.5:6379');
I will change and work out how to add multiple different servers if you are happy using predis. It seems to work ok otherwise.