search

elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

Rework of the theme classes #3735

Closed Spuds closed 7 months ago

Spuds commented 7 months ago

Refactor themeloader into smaller more common action functions Pull a lot of stuff from base theme back into the abstract, custom themes do not need all that cruft in their theme.php and they can still override when they want. Various cleanup for other files I had to open

codecov[bot] commented 7 months ago

Codecov Report

Attention: 268 lines in your changes are missing coverage. Please review.

Comparison is base (7f6f2a7) 27.73% compared to head (750b726) 28.04%. Report is 3 commits behind head on development.

Files Patch % Lines
sources/ElkArte/Themes/Theme.php 61.57% 151 Missing :warning:
sources/ElkArte/Themes/ThemeLoader.php 56.49% 77 Missing :warning:
sources/Security.php 53.96% 29 Missing :warning:
themes/default/index.template.php 50.00% 6 Missing :warning:
sources/ElkArte/Server.php 54.54% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3735 +/- ## ================================================= + Coverage 27.73% 28.04% +0.30% - Complexity 16467 16480 +13 ================================================= Files 425 425 Lines 82983 83036 +53 ================================================= + Hits 23018 23288 +270 + Misses 59965 59748 -217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.