search

elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
176 stars 61 forks source link

Begin to pull theme JS and CSS in to their own class #3745

Closed Spuds closed 9 months ago

Spuds commented 9 months ago

Cleans up theme.php which was getting to an overwhelming number of methods hardening and easy cleanup === [] etc

codecov[bot] commented 9 months ago

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (4d82cbe) 32.89% compared to head (4293a1e) 32.87%. Report is 1 commits behind head on development.

Files Patch % Lines
sources/subs/Themes.subs.php 5.35% 53 Missing :warning:
sources/ElkArte/Themes/Javascript.php 68.33% 38 Missing :warning:
sources/ElkArte/Themes/Css.php 55.17% 26 Missing :warning:
sources/ElkArte/Themes/Theme.php 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3745 +/- ## ================================================= - Coverage 32.89% 32.87% -0.03% - Complexity 16456 16457 +1 ================================================= Files 430 432 +2 Lines 83377 83353 -24 ================================================= - Hits 27424 27399 -25 - Misses 55953 55954 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.