elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
176 stars 61 forks source link

Continued refresh #3758

Closed Spuds closed 9 months ago

Spuds commented 9 months ago

use static on closures that don't need $this arrow functions fn() => for some one line closures replace those \ElkArte\AdminController\XYZ calls with an import and XYZ::class some hardening useless else removal early returns remove list() cast ints in some of the queries positive logic in some if

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 40.43687% with 1118 lines in your changes are missing coverage. Please review.

Project coverage is 34.08%. Comparing base (c1eba29) to head (346263d). Report is 1 commits behind head on development.

Files Patch % Lines
...s/ElkArte/AdminController/ManageCalendarModule.php 0.00% 83 Missing :warning:
sources/ElkArte/AttachmentsDirectory.php 8.77% 52 Missing :warning:
...es/ElkArte/MessagesCallback/BodyParser/Compact.php 0.00% 52 Missing :warning:
...lkArte/ScheduledTasks/Tasks/UserAccessMentions.php 0.00% 44 Missing :warning:
sources/ElkArte/Modules/Poll/Post.php 19.60% 41 Missing :warning:
sources/ElkArte/Packages/Packages.php 33.92% 37 Missing :warning:
sources/ElkArte/Modules/Drafts/PersonalMessage.php 0.00% 33 Missing :warning:
sources/ElkArte/MessagesDelete.php 0.00% 32 Missing :warning:
sources/ElkArte/Modules/Calendar/Post.php 0.00% 30 Missing :warning:
sources/ElkArte/MetadataIntegrate.php 0.00% 29 Missing :warning:
... and 108 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3758 +/- ## ================================================= - Coverage 34.39% 34.08% -0.32% + Complexity 16571 16511 -60 ================================================= Files 436 430 -6 Lines 84007 84031 +24 ================================================= - Hits 28892 28639 -253 - Misses 55115 55392 +277 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.