search

elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
176 stars 61 forks source link

Additonal areas of cleanup #3762

Closed Spuds closed 8 months ago

Spuds commented 8 months ago

Quick pass through themes and install areas, mostly to reverse !empty and !isset sillyness

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 43.41463% with 116 lines in your changes are missing coverage. Please review.

Project coverage is 33.30%. Comparing base (f8b62c0) to head (d68f678). Report is 1 commits behind head on development.

Files Patch % Lines
themes/default/ProfileOptions.template.php 27.77% 39 Missing :warning:
themes/default/Admin.template.php 17.39% 19 Missing :warning:
themes/default/GenericMessages.template.php 6.25% 15 Missing :warning:
themes/default/GenericMenu.template.php 42.85% 8 Missing :warning:
themes/default/Register.template.php 0.00% 8 Missing :warning:
themes/default/Xml.template.php 0.00% 8 Missing :warning:
themes/default/MessageIndex.template.php 42.85% 4 Missing :warning:
themes/default/Post.template.php 55.55% 4 Missing :warning:
themes/default/Display.template.php 86.66% 2 Missing :warning:
themes/default/ManageMembers.template.php 50.00% 2 Missing :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3762 +/- ## ================================================= - Coverage 34.38% 33.30% -1.08% Complexity 16512 16512 ================================================= Files 430 429 -1 Lines 84040 83467 -573 ================================================= - Hits 28893 27800 -1093 - Misses 55147 55667 +520 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.