elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

No longer of any use with ubiquitous https #3770

Closed Spuds closed 5 months ago

Spuds commented 5 months ago

This was updated from a sha1 to sha256 a decade ago which was a good improvement.

The intent was to pass a hashed (with session id) password in the login form to help protect it, vs passing it in clear text.

Now days with httpS there is no longer any need for this.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 33.27%. Comparing base (d3627c0) to head (62d837b). Report is 1 commits behind head on development.

Files Patch % Lines
themes/default/Login.template.php 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3770 +/- ## ================================================= + Coverage 31.05% 33.27% +2.21% + Complexity 16522 16507 -15 ================================================= Files 424 431 +7 Lines 81969 83465 +1496 ================================================= + Hits 25456 27771 +2315 + Misses 56513 55694 -819 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.