search

elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

Chunk upload #3771

Closed Spuds closed 5 months ago

Spuds commented 5 months ago

Adding of Chunked Attachment Uploads

Uploaded attachments are cut into chunks, sent, re-combined on the server, and then processed as if it was sent as one large file

This has retries on the chunks should a network glitch occur and allows multiple sends to be occurring which could improve speed.

This simplifies the "upload_max_filesize" as each chunk will be small enough to pass the limit.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 37.08440% with 246 lines in your changes are missing coverage. Please review.

Project coverage is 33.66%. Comparing base (62d837b) to head (2304d26). Report is 1 commits behind head on development.

Files Patch % Lines
...s/ElkArte/Attachments/TemporaryAttachmentChunk.php 0.00% 160 Missing :warning:
sources/ElkArte/Controller/Attachment.php 24.39% 31 Missing :warning:
...ElkArte/Attachments/TemporaryAttachmentProcess.php 82.35% 21 Missing :warning:
...ources/ElkArte/Attachments/TemporaryAttachment.php 44.44% 15 Missing :warning:
...urces/ElkArte/Attachments/AttachmentsDirectory.php 50.00% 6 Missing :warning:
sources/subs/Attachments.subs.php 0.00% 4 Missing :warning:
...ources/ElkArte/Notifications/PostNotifications.php 0.00% 2 Missing :warning:
sources/ElkArte/AdminController/ManageFeatures.php 66.66% 1 Missing :warning:
sources/ElkArte/AdminController/ManagePosts.php 0.00% 1 Missing :warning:
...s/ElkArte/Attachments/TemporaryAttachmentsList.php 0.00% 1 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3771 +/- ## ================================================= + Coverage 33.27% 33.66% +0.39% - Complexity 16507 16618 +111 ================================================= Files 431 434 +3 Lines 83465 84276 +811 ================================================= + Hits 27771 28372 +601 - Misses 55694 55904 +210 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.