elkarte / Elkarte

ElkArte Forum. A free, open source, modern discussion forum / BB
https://elkarte.github.io/Elkarte/
BSD 3-Clause "New" or "Revised" License
175 stars 61 forks source link

Remove Allow other to email me #3777

Closed Spuds closed 4 months ago

Spuds commented 4 months ago

This was a rather dated option, and most never want their email shared on a forum anyway. They can always PM and ask to take it to email.

With this change only mods (and the user) can see an email. Only mods can search by email. Email envelope is not shown unless you have those permissions (it used to show but say hidden). Uses mailto: on links for the few that can email. Simplifies the email checks etc.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 59.57447% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 33.02%. Comparing base (cfc25d6) to head (8e05061). Report is 1 commits behind head on development.

Files Patch % Lines
sources/ElkArte/Controller/Memberlist.php 68.42% 6 Missing :warning:
sources/ElkArte/Controller/Groups.php 0.00% 4 Missing :warning:
sources/subs/Members.subs.php 50.00% 3 Missing :warning:
sources/ElkArte/Controller/Emailmoderator.php 66.66% 1 Missing :warning:
sources/ElkArte/Controller/PersonalMessage.php 0.00% 1 Missing :warning:
sources/ElkArte/Controller/Register.php 0.00% 1 Missing :warning:
sources/ElkArte/MessagesCallback/PmRenderer.php 0.00% 1 Missing :warning:
sources/ElkArte/MessagesCallback/Renderer.php 0.00% 1 Missing :warning:
sources/Security.php 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #3777 +/- ## ================================================= + Coverage 32.97% 33.02% +0.04% + Complexity 12931 12908 -23 ================================================= Files 288 288 Lines 62619 62516 -103 ================================================= - Hits 20647 20643 -4 + Misses 41972 41873 -99 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.