search

elki-project / elki

ELKI Data Mining Toolkit
https://elki-project.github.io/
GNU Affero General Public License v3.0
785 stars 323 forks source link

LOF algo suggestion #109

Closed lsqworld closed 1 year ago

lsqworld commented 1 year ago

LOF.java, comparing to scikit-learn _lof.py, shall we also make a small addon to the 'sum' variable instead of returning Double.POSITIVE_INFINITY, to be compatible on scene which number of duplicated points is greater than K ?

image image

kno10 commented 1 year ago

Positive infinity is the appropriate value, which is easily seen if you make this epsilon arbitrarily small. Hence no need for the epsilon. In my opinion, this is better than hiding the problem with a finite value such as 1e10!

P.S. please choose meaningful issue titles, "algo suggestion" is poor.

kno10 commented 1 year ago

Closing, as the current behaviour is desired.