search

elki-project / elki

ELKI Data Mining Toolkit
https://elki-project.github.io/
GNU Affero General Public License v3.0
780 stars 321 forks source link

Code quality fix - Utility classes should not have public constructors. #17

Closed faisal-hameed closed 7 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1118 - Utility classes should not have public constructors. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1118

Please let me know if you have any questions.

Faisal Hameed

codecov-io commented 8 years ago

Current coverage is 33.00%

Merging #17 into master will not affect coverage as of 4de8d8a

@@            master     #17   diff @@
======================================
  Files         1332    1332       
  Stmts        66238   66238       
  Branches     14284   14284       
  Methods          0       0       
======================================
  Hit          21863   21863       
  Partial       2537    2537       
  Missed       41838   41838

Review entire Coverage Diff as of 4de8d8a

Powered by Codecov. Updated on successful CI builds.

kno10 commented 8 years ago

The reason why the constructors are private should be in the documentation for future reference.

faisal-hameed commented 8 years ago

@kno10 Agreed. Along with documentation It would be better if you could define important coding standards for contributors for the maintainability of this repo.

faisal-hameed commented 8 years ago

@kno10 I am not sure whether you are agree with this change or not. Please close it if not.