search

elki-project / elki

ELKI Data Mining Toolkit
https://elki-project.github.io/
GNU Affero General Public License v3.0
780 stars 321 forks source link

Bugfix: Histogram visualizer now uses double array instead of NumberVector #19

Closed patrickkostjens closed 8 years ago

patrickkostjens commented 8 years ago

This is a new fix for the same problem as in my previous pull request (#18). As per your suggestion there, I solved the problem in the visualization instead of the creation of the histogram.

codecov-io commented 8 years ago

Current coverage is 33.04%

Merging #19 into master will decrease coverage by -0.01% as of aad943c

@@            master     #19   diff @@
======================================
  Files         1332    1332       
  Stmts        66138   66138       
  Branches     14253   14253       
  Methods          0       0       
======================================
- Hit          21860   21858     -2
- Partial       2536    2538     +2
  Missed       41742   41742

Review entire Coverage Diff as of aad943c

Powered by Codecov. Updated on successful CI builds.

kno10 commented 8 years ago

Thank you! I've merged this as 42fbc8a9228614df659727e32e5b1d6f2bdf1f0f, but also removed the generic from the HistogramResult altogether in 792b8214f6223fec6b6b536b70ab9af16c6460e3. It was only used with double[] and probably cannot be used (meaningful) differently (Double would be quite expensive, and should be done differently). Maybe it will be further changed later.