elki-project / elki

ELKI Data Mining Toolkit
https://elki-project.github.io/
GNU Affero General Public License v3.0
780 stars 321 forks source link

Partial code cleanup based on IDE warnings #22

Closed patrickkostjens closed 8 years ago

patrickkostjens commented 8 years ago

Based on warnings from my IDE, I did some code cleaning. The issues I fixed fall in the following categories:

Additionally, I updated the copyright year for the files I modified.

kno10 commented 8 years ago

Most of these changes are not good, and some may even introduce bugs, sorry.

Sometimes, the automatic recommendations of IDEs are not good.

patrickkostjens commented 8 years ago

I can agree with your reasoning in most of the cases. For the others, see my comments there.

I agree not all IDE recommendations may be valid and I guess it is better for me to stick with the parts of the code that I am actually using/changing since I do not know enough about the project yet. I appreciate you reviewing them anyway since it gives me a better understanding of some conventions and choices within the project.