search

elki-project / elki

ELKI Data Mining Toolkit
https://elki-project.github.io/
GNU Affero General Public License v3.0
780 stars 321 forks source link

Eliminated duplicate code within IntegerMinMax class. Deprecated code was left intact. #35

Closed commandini closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #35 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     36.74%   36.74%   +<.01%     
  Complexity     9123     9123              
============================================
  Files          1639     1639              
  Lines         83958    83956       -2     
  Branches      15327    15325       -2     
============================================
+ Hits          30848    30849       +1     
+ Misses        50325    50323       -2     
+ Partials       2785     2784       -1
Impacted Files Coverage Δ Complexity Δ
...n/java/de/lmu/ifi/dbs/elki/math/IntegerMinMax.java 66.66% <100%> (+3.5%) 15 <0> (ø) :arrow_down:
...s/elki/index/idistance/InMemoryIDistanceIndex.java 75% <0%> (-2.44%) 17% <0%> (-1%)
...ng/gdbscan/parallel/ParallelGeneralizedDBSCAN.java 83.33% <0%> (+1.58%) 3% <0%> (ø) :arrow_down:
.../ifi/dbs/elki/logging/progress/FiniteProgress.java 91.11% <0%> (+6.66%) 15% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e3d24d...e3a682f. Read the comment docs.

kno10 commented 7 years ago

A similar code also exists in DoubleMinMax. Fixed both in e2585b195dac8204a8bfdc4d00a41b755de85c80