elki-project / elki

ELKI Data Mining Toolkit
https://elki-project.github.io/
GNU Affero General Public License v3.0
785 stars 323 forks source link

Feature/set distance tests #67

Closed ARandomTree closed 4 years ago

ARandomTree commented 4 years ago

Added tests for set distances.

Fixed an error in Jaccard similarities in the according distance class and in the bitvector class. If two empty Vectors were given, the similirarity was NaN but should have been 1 and the distance should be 0.

codecov[bot] commented 4 years ago

Codecov Report

Merging #67 into master will increase coverage by 0.13%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
+ Coverage     49.85%   49.98%   +0.13%     
- Complexity    11548    11711     +163     
============================================
  Files          1667     1667              
  Lines         81655    81928     +273     
  Branches      14700    14765      +65     
============================================
+ Hits          40709    40953     +244     
+ Misses        37915    37914       -1     
- Partials       3031     3061      +30
Impacted Files Coverage Δ Complexity Δ
...a/elki/distance/set/JaccardSimilarityDistance.java 71.66% <50%> (+71.66%) 33 <0> (+33) :arrow_up:
...i-core-data/src/main/java/elki/data/BitVector.java 18.91% <50%> (+3.46%) 14 <1> (+5) :arrow_up:
.../main/java/elki/evaluation/clustering/Entropy.java 55.03% <0%> (-22.14%) 20% <0%> (-6%)
...evaluation/clustering/ClusterContingencyTable.java 31.75% <0%> (-12.8%) 9% <0%> (+1%)
...ki-core-math/src/main/java/elki/math/MathUtil.java 93.88% <0%> (-1.69%) 189% <0%> (+89%)
...re/src/main/java/elki/result/EvaluationResult.java 40.9% <0%> (-0.65%) 4% <0%> (ø)
...va/elki/result/textwriter/MultipleFilesOutput.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
...datasource/ConcatenateFilesDatabaseConnection.java 15.49% <0%> (+0.39%) 0% <0%> (ø) :arrow_down:
...n/java/elki/utilities/datastructures/BitsUtil.java 72.69% <0%> (+1.61%) 206% <0%> (+4%) :arrow_up:
...elki/evaluation/clustering/EvaluateClustering.java 10.34% <0%> (+2.23%) 0% <0%> (ø) :arrow_down:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c205d23...ebe8675. Read the comment docs.

kno10 commented 4 years ago

Closed with commit 28507c6157a493ce344673cd78a65b24c42a1996