elkoenio / hudson-tray-tracker

Automatically exported from code.google.com/p/hudson-tray-tracker
0 stars 0 forks source link

"Build is stuck" reported as "Failed" and shows as red #67

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?

1. Have Hudson + slaves, have two projects, one of which triggers the other, 
and the other is tied to a particular slave
2. Take the slave that's needed by the second project offline and then trigger 
a build of the first.
3. When the first build completes, it triggers the second, which then sits 
there waiting for its slave to become available.

What is the expected output? What do you see instead?

I would expect to see a pop-up bubble message saying that the second project is 
"stuck", the icon for that project show as a grey colour, and be reported as 
"stuck" in the tooltip.

What I actually see is a pop-up bubble message saying that the "Build FAILED" 
(which it didn't), the icon for that project turns red (which makes our 
developers think that someone has broken the code, which isn't true), and it is 
reported as "stuck" in the tooltop (which is correct).

What version of the product are you using? On what operating system?

Hudson Tray Tracker version 0.11.1.0  (which is the latest I can find at the 
time of writing)

Please provide any additional information below.

This issue came about because we have a few projects whose job it is to deploy 
the code onto particular machines that then host the latest software (makes 
testing easier), and I took one of those machines offline for maintenance.

Ideally (but this is not essential), the overall status icon should show a mix 
of grey and green/red/amber when one or more projects are grey, just to 
highlight the fact that one or more projects are in an "unknown" state. e.g. 
half-grey+half-green for "all builds we know about are ok, but we don't know 
about all of them".

I suspect that this issue resulted from the code changes done as part of issue 
7 (http://code.google.com/p/hudson-tray-tracker/issues/detail?id=7)

In my opinion, "stuck" is closer to "we don't know what the state of this build 
is" (i.e. grey) than "we know that this build is broken" (i.e. red).
Red causes developers to look for source code changes that they made that may 
have broken things; Grey causes developers to check the health of the build 
system.
I don't think that suspending a slave (in a controlled manner) that did not 
result in any failed builds should not cause HTT to report any failed builds...

Original issue reported on code.google.com by pjdar...@gmail.com on 7 Dec 2010 at 1:51

GoogleCodeExporter commented 8 years ago
Thanks for reporting this issue. Can you test a beta version I have just 
uploaded? The version number is 0.12.
In this version, the "H" letter within the icon becomes gray when one of the 
build is stuck.
Let me know what you think.

Thanks,
Alexis

Original comment by Alexis.S...@gmail.com on 3 Mar 2011 at 5:56

GoogleCodeExporter commented 8 years ago
I've had a go testing this beta version.  I like it.  The icon doesn't go red 
and so the rest of the dev team don't think have broken the build - but the 
icon does look different and flags that something is not right.

It even copes well with  acknolegding a build being stuck when its stuck status 
comes and goes due to the upstream job running.

To explain, I have two jobs, call then A and B.  B is downstream of A and 
depends on a particular slave.  When that slave is offline, the grey 'stuck' H 
goes away if job A is running, job B is waiting for the upstream job - its not 
stuck.  When A finishes job B is stuck again and the H turns grey.  
Acknoledging Job B's status makes the grey icon go away as expected.  I was 
expecting that when Job A ran and finished, Job B's stuck status would 
re-appear in the tray icon.  I doesn't which is great. Well done.

Many Thanks,
Graham

Original comment by grhm.sm...@gmail.com on 11 Mar 2011 at 10:01

GoogleCodeExporter commented 8 years ago
(Hmm, that's odd, the comment I added on the 3rd march isn't listed here)

Anyway, the upshot is that I've been running the beta version for a week now 
and I think it's good.
It certainly fixes the bug/enhancement-request that I reported.

The beta also includes the fix for the other issue I reported ages ago, so I'm 
happy.

Original comment by pjdar...@gmail.com on 11 Mar 2011 at 11:02