[BUG] Bad error message on empty string interpolation `${}` - Githubissues

elkowar / eww

ElKowars wacky widgets

https://elkowar.github.io/eww

MIT License

9.11k stars 377 forks source link

[BUG] Bad error message on empty string interpolation `${}` #515

Open ankrisac opened 2 years ago

ankrisac commented 2 years ago

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug

When using an empty string interpolation expression ${}, eww reports Input ended unexpectedly at the beginning of the file.

Reproducing the issue

Minimum config to reproduce the bug

eww.yuck

; Comment

(defvar var "${}")

Running eww daemon

$ eww daemon
...

error: Input ended unexpectedly. Check if you have any unclosed delimiters
  ┌─ /home/ankrisac/.config/eww/eww.yuck:1:1
  │
1 │ ; Comment
  │ ─

Expected behaviour

Ideally ${} should be a valid expression resulting in an empty string

Additional context

No response

elkowar commented 2 years ago

The errror message here is definitely bad, that needs to be improved! However, I don't think it should result in an empty string, as the empty string interpolation is just an invalid expression that cannot be evaluated, and thus should still result in an error - just a more readable one!