elkowar / eww

ElKowars wacky widgets
https://elkowar.github.io/eww
MIT License
9.11k stars 377 forks source link

[BUG] Eww isn't hot reloading with symlinked configs #868

Open samchouse opened 1 year ago

samchouse commented 1 year ago

Checklist before submitting an issue

Description of the bug

Eww doesn't hot reload when using symlinks for the config. I'm using https://github.com/SuperCuber/dotter so it auto creates these symlinks.

Reproducing the issue

  1. Create a symlink to eww configs
  2. Edit the config
  3. Eww doesn't hot reload

Expected behaviour

It hot reloads

Additional context

No response

elkowar commented 1 year ago

I'm unable to reproduce that issue, for me hot-reloading configs with symlinks does work as expected -- do you experience the same issue with non-symlinked config? Or if you open eww by referring to the symlink target rather than the symlink?

samchouse commented 1 year ago

A non-symlinked config works properly and referring eww to the symlink target also works properly. It used to work properly but it broke a couple days into having eww.

samchouse commented 1 year ago

It's because of symlinking the files and not the directory. I've changed it now since notify doesn't support it (https://github.com/notify-rs/notify/issues/381) to a directory symlink. It would be better to not have to do this though since some other stuff (from my scripts) is generated to the config directory.